rtl8139: remove magic numbers #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the many magic numbers for various ports and flags and gives them names, and also switches to using Pio objects directly instead of the inb/outb methods that have a deprecation notice on them right now (or at least "TODO: Remove this", which is close enough to a deprecation notice).
|
There shouldn't be any behaviour changes in this. The image boots up just fine, and the PCI info output during boot using qemu is identical, and pings still work when I use net=tap. I haven't found an easy way to test that other network connectivity is working, so I haven't been able to do in-depth testing. |
|
This is fantastic work. Glad you found the net=tap, arping and ping are the best tests so far. The other drivers need this kind of fixup, the more places |
jackpot51
added a commit
that referenced
this pull request
Dec 31, 2015
rtl8139: remove magic numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the many magic numbers for various ports and flags and gives them names, and also switches to using Pio objects directly instead of the inb/outb methods that have a deprecation notice on them
right now (or at least "TODO: Remove this", which is close enough to a deprecation notice).